LWJGL
May 21, 2013, 23:11:34 *
Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length
News: LWJGL 2.9.0 released!
 
   Home   Help Search Login Register  



Pages: [1]
  Print  
Author Topic: [FIXED] Duplicate GL_RED  (Read 1036 times)
ra4king
Newbie
*
Posts: 33


I'm the King!


WWW
« on: June 11, 2012, 12:29:02 »

GL11 and GL30 both have a GL_RED constant with the same value. This causes a conflict error when statically importing both classes. Fix is to simply remove GL_RED from GL30 Smiley

Also, add a test case that *-imports all GLXX and extensions classes to test for duplicates.

This bug was found by theagentd and sproingie suggested the test case, so credit goes to them. Smiley
Logged

-Roi
Matthias
Talks Too Much
***
Posts: 180


WWW
« Reply #1 on: June 11, 2012, 13:50:31 »

While it seems inconsistent to have constants/methods declared in GL30 which are already in GL10, removing the one from GL30 now would break existing application. I would defer that cleanup to LWJGL 3.0.
Logged

princec
Nerdus Imperius
*****
Posts: 1868



WWW
« Reply #2 on: June 11, 2012, 16:02:13 »

I believe this would only trivially break source code; the constants are otherwise inlined in to bytecode.

And let's face it, there's not a lot of LWJGL OpenGL3.0 code out there is there.

Cas Smiley
Logged

spasi
Nerdus Imperius
*****
Posts: 752



WWW
« Reply #3 on: June 19, 2012, 03:54:44 »

Thanks for the report, it's been removed.
Logged
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines
SMFAds for Free Forums
Valid XHTML 1.0! Valid CSS!